Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files with multi-byte chars detected as fields from FireFox 5 #84

Closed
OrangeDog opened this issue Jul 15, 2011 · 3 comments
Closed

Files with multi-byte chars detected as fields from FireFox 5 #84

OrangeDog opened this issue Jul 15, 2011 · 3 comments

Comments

@OrangeDog
Copy link
Contributor

I can't tell whether this is a bug with FireFox, with all other browsers, or with formidable.
Using formidable 1.0.2, node 0.4.8.

A file with a 3-byte character (tested with U+200F and U+2010) in its name, when uploaded via FireFox 5, is parsed as a field rather than a file. In my particular case, this results in "max field size exceeded" errors. Everything works correctly when using latest Chrome or IE8.

@OrangeDog
Copy link
Contributor Author

On further inspection, FireFox gives this header
Content-Disposition: form-data; name="foo"; filename="bar‏.mp4"

While Chrome, for example, sends this
Content-Disposition: form-data; name="foo"; filename="bar?.mp4"

@OrangeDog
Copy link
Contributor Author

While on the subject of incoming_form.js:283

Chrome will not escape a ; in a filename
FireFox will escape " as "

@felixge
Copy link
Collaborator

felixge commented Jul 18, 2011

Yeah, looks like some stuff needs to be fixed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants