PR for more webpack-friendly usage #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tmpDir() deprecation issue has already been fixed in 321e92 and released with v1.1.1. Meanwhile, commenting out the GENTLY stuff breaks the test suite and thus might not be the correct approach to this problem by itself. |
|
@MagdaleneLee impossible to be merged, but you can find some help in #337. More specifically the #337 (comment). |
|
I'd like to add that I intend to look into the webpack-issue as soon as I can. |
|
I'll try to configure my webpack to ignore gently
…On 18 Jan 2017 14:51, "Jonas Amundsen" ***@***.***> wrote:
I'd like to add that I intend to look into the webpack-issue as soon as I
can.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#416 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQet3WbUntqo6Iq2X565lUDBGNILYl5gks5rTm04gaJpZM4LnM2z>
.
|
|
Thanks. Issue #337 seemed to be the one which would help. I'm going to try
and build. You guys are so responsive, I really appreciate it
…On Wed, Jan 18, 2017 at 2:49 PM, Charlike Mike Reagent < ***@***.***> wrote:
@MagdaleneLee <https://github.com/MagdaleneLee> impossible to be merged,
but you can find some help in #337
<#337>, and specifically
the #337 (comment)
<#337 (comment)>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#416 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQet3foOJ0x0IYo1FmDrhh4RvJWlQjCAks5rTmyygaJpZM4LnM2z>
.
|
|
Yea, no problem. :) Maybe it is because we are the new maintainers, haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commented out Gently (for non-testing usage)
update os.tmpDir to os.tmpdir (compliant with newer node versions)