Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Remove callback from types in 5.x #210

Closed
jankapunkt opened this issue Aug 4, 2023 · 4 comments · Fixed by #211
Closed

TypeScript: Remove callback from types in 5.x #210

jankapunkt opened this issue Aug 4, 2023 · 4 comments · Fixed by #211

Comments

@jankapunkt
Copy link
Member

In release 5.x (#194) we dropped all callbacks, so types should reflect that, too. PR should target only release-5.0.0
@jankapunkt jankapunkt mentioned this issue Aug 4, 2023
Closed
@shrihari-prakash shrihari-prakash mentioned this issue Aug 4, 2023
Merged
@shrihari-prakash
Copy link
Contributor

@jankapunkt could you remove the PR to remove callbacks? #211

@jankapunkt jankapunkt linked a pull request Aug 4, 2023 that will close this issue
Removed callback support in typings file. #211
Merged
@jankapunkt
Copy link
Member Author

@shrihari-prakash did you mean "review"?

@shrihari-prakash
Copy link
Contributor

Haha yes :)

@jankapunkt
Copy link
Member Author

All changes are now public at https://node-oauthoauth2-server.readthedocs.io/en/latest/?badge=latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed callback support in typings file. shrihari-prakash/node-oauth2-server
2 participants
@jankapunkt @shrihari-prakash