unsupported response type "id_token code"

[michielbdejong]

This is the next problem I ran into after finding my way around #1432:

echo '{"redirect_uris":["http://localhost:3001/redirect"],"client_id":"coolApp","client_secret":"e058034d5c892a0eac9143275daaf4d8","response_types":["code"],"grant_types":["authorization_code"],"application_type":"web","id_token_signed_response_alg":"RS256","token_endpoint_auth_method":"client_secret_basic"}' > .db/oidc/op/clients/_key_coolApp.json

curl -ki "https://localhost:8443/authorize?response_type=id_token%20code&redirect_uri=http%3A%2F%2Flocalhost%3A3001%2Fredirect&scope=openid%20profile%20offline_access&client_id=coolApp&code_challenge_method=S256&code_challenge=M3CBok-0kQFc0GUz2YD90cFee0XzTTru3Eaj0Ubm-oc&state=84ae2b48-eb1b-4000-8782-ac1cd748aeb0"
HTTP/1.1 302 Found
X-Powered-By: solid-server/5.3.0
Vary: Accept, Authorization, Origin
Access-Control-Allow-Credentials: true
Access-Control-Expose-Headers: Authorization, User, Location, Link, Vary, Last-Modified, ETag, Accept-Patch, Accept-Post, Updates-Via, Allow, WAC-Allow, Content-Length, WWW-Authenticate, MS-Author-Via
Allow: OPTIONS, HEAD, GET, PATCH, POST, PUT, DELETE
Location: http://localhost:3001/redirect?error=unsupported_response_type&error_description=Unsupported+response+type&state=84ae2b48-eb1b-4000-8782-ac1cd748aeb0
Content-Type: text/plain; charset=utf-8
Content-Length: 171
Date: Fri, 19 Jun 2020 11:19:48 GMT
Connection: keep-alive

Found. Redirecting to http://localhost:3001/redirect?error=unsupported_response_type&error_description=Unsupported+response+type&state=84ae2b48-eb1b-4000-8782-ac1cd748aeb0

[michielbdejong]

https://github.com/solid/oidc-op/blob/d0f73f6634efa60059fb7bda1913cfe303b9502d/src/Provider.js#L21 does list it

[michielbdejong]

Ah interesting, the id_token code type was actually added in nodeSolidServer/oidc-op@f735d42#diff-da2de9739cd17cd7703775f05b75127dR20.

oidc-op master branch is at version 0.7

[michielbdejong]

Ah, it loads the provider config from disk.

mv .db/oidc/op/provider.json .

fixes it.

Let's add this to the upgrade docs then, maybe? @jaxoncreed what do you think?

[michielbdejong]

See #1435

[michielbdejong]

covered in the upgrade instructions now.