Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

special release for all release lines to fix regressions from last security release #401

Closed
MylesBorins opened this issue Dec 21, 2018 · 3 comments
Closed

special release for all release lines to fix regressions from last security release #401

MylesBorins opened this issue Dec 21, 2018 · 3 comments

Comments

@MylesBorins
Copy link
Contributor

The last security release included a regression in 6 / 8 / 10 in HTTP binary response body. There was also no CLI option to change the maximum header size in 6 / 8 / 10 / 11.

I've proposed releases for all release lines to account for this, planning to push them out next Wednesday the 26th. They are Semver-Minor and include no other commits (aside from 10 that required a single commit to fix a regression in test suite)

11: nodejs/node#25175
10: nodejs/node#25176
8: nodejs/node#25177
6: nodejs/node#25178

If anyone has concerns please lmk
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/tsc @nodejs/security @nodejs/lts

@mcollina
Copy link
Member

sgtm

@mhdawson
Copy link
Member

mhdawson commented Jan 2, 2019

Closing since releases are out.

@mhdawson mhdawson closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @MylesBorins @mhdawson