New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snake_case for all local names and parameters #189

Closed

boingoing opened this issue Mar 22, 2017 · 1 comment

Assignees

boingoing commented Mar 22, 2017

We aren't consistent in naming our locals or parameters with respect to their casing. Node.js, apparently, prefers snake_casing for these.

  if (staticPropertyCount > 0) {
    std::vector<napi_property_descriptor> staticDescriptors;
    staticDescriptors.reserve(staticPropertyCount);

Should become

  if (static_property_count > 0) {
    std::vector<napi_property_descriptor> static_descriptors;
    static_descriptors.reserve(static_property_count);

aruneshchandra assigned boingoing

boingoing mentioned this issue

Convert all locals and parameter names to snake_case #193

Merged

Author

boingoing commented Mar 23, 2017

Fixed by #193

boingoing closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment