Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to use netlify on nodejs-ko #411

Closed
outsideris opened this issue Sep 16, 2019 · 7 comments
Closed

Request to use netlify on nodejs-ko #411

outsideris opened this issue Sep 16, 2019 · 7 comments

Comments

@outsideris
Copy link

In @nodejs/nodejs-ko , we are using GitHub pages and actions for our blog for nodejs news.

We need to build a preview on PR because we missed broken markdown in code review. We will use netlify for the only preview because blog URL is hard to change.

Thanks. nodejs/nodejs-ko#877

@Trott
Copy link
Member

Trott commented Sep 16, 2019

@nodejs/tsc @nodejs/community-committee

@mhdawson
Copy link
Member

Privileges that need to be granted: https://www.netlify.com/docs/github-permissions/

I'd assume we would enable only for the single repository.

@nschonni
Copy link
Member

Is the separate repo still needed outside https://github.com/nodejs/nodejs.org/tree/master/locale/ko

@Trott
Copy link
Member

Trott commented Sep 17, 2019

Is the separate repo still needed outside https://github.com/nodejs/nodejs.org/tree/master/locale/ko

@nodejs/i18n Is the https://github.com/nodejs/nodejs-ko repo necessary? Or should everything be happening in https://github.com/nodejs/nodejs.org/tree/master/locale/ko and CrowdIn at this point?

@Trott
Copy link
Member

Trott commented Sep 17, 2019

Is the separate repo still needed outside https://github.com/nodejs/nodejs.org/tree/master/locale/ko

@nodejs/i18n Is the https://github.com/nodejs/nodejs-ko repo necessary? Or should everything be happening in https://github.com/nodejs/nodejs.org/tree/master/locale/ko and CrowdIn at this point?

There's a gh-pages branch on the https://github.com/nodejs/nodejs-ko so it has a web presence that I imagine most of the other translation repos don't.

@yous
Copy link

yous commented Sep 18, 2019

Yes, @nodejs/nodejs-ko translate almost every release post on https://github.com/nodejs/nodejs-ko, which is served on separate website (https://nodejs.github.io/nodejs-ko/). Also there is a Twitter bot (https://twitter.com/nodejs_ko) for notifications.

@Trott
Copy link
Member

Trott commented Jun 1, 2023

This all got a year or more out of date and then the GitHub repo was archived in March. I'm going to close this issue.

@Trott Trott closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants