Skip to content
This repository has been archived by the owner on Nov 28, 2020. It is now read-only.

Audit benchmarks on v6.x #162

Closed
MylesBorins opened this issue Oct 18, 2017 · 5 comments
Closed

Audit benchmarks on v6.x #162

MylesBorins opened this issue Oct 18, 2017 · 5 comments

Comments

@MylesBorins
Copy link

MylesBorins commented Oct 18, 2017

The delta between v6.x and master has gotten non trivial. I think it would make sense to Audit the 6.x branch and see what needs to be done to get things up to date

@joyeecheung
Copy link
Member

Are you talking about the benchmarks on https://benchmarking.nodejs.org/ or the core micro-benchmarks?

@mhdawson
Copy link
Member

Agreed, not really sure what you are asking for. Can you add some more detail.

@MylesBorins
Copy link
Author

I was referring to the benchmark folder in the 6.x release line. The tooling is quite out of date

@joyeecheung
Copy link
Member

The benchmark tooling in the core was rewritten during v6.x as semver-major so it is not available in v6.x (nodejs/node#7094), therefore almost every update in the benchmark folder does not apply to v6.x.

I think we should skip backporting benchmark commits, and ask people updating benchmarks in their PR to split those changes into separate commits?

@joyeecheung
Copy link
Member

Uh...wait, if you are talking about bringing the existing benchmark folder in v6.x branch up-to-date, then yes, it needs to be audited because there could probably be some commits that depend on the new tooling landed. Although...do we still run the benchmarks in the v6.x branch? Is it necessary? If we are comparing the performance differnce between v6.x and other later release lines, since the tooling in v6.x does not generate the same output as others, we probably can't use them as-is anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants