Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip VS2015 build if node version is >= 10 #1029

Closed
targos opened this issue Dec 4, 2017 · 2 comments
Closed

Skip VS2015 build if node version is >= 10 #1029

targos opened this issue Dec 4, 2017 · 2 comments

Comments

@targos
Copy link
Member

targos commented Dec 4, 2017

I'm working on the update to V8 6.4 (should be ready in 6-7 weeks) and only VS2017 is able to compile this version.
You can see the windows test job is already failing with the canary branch: https://ci.nodejs.org/job/node-test-commit-windows-fanned/13987/

Edit: CI with my 6.4 branch: https://ci.nodejs.org/job/node-test-commit/14548/

@joaocgreis
Copy link
Member

VS2017 release machines have been active for a few days, nightlies of v10 are built with them. I haven't seen issues, I'll move forward with adapting the test CI (this will also unlock nodejs/node#16969).

@joaocgreis
Copy link
Member

Done, for node >= 10 only VS2017 is used now.

Here is a rebuild of the job mentioned above: https://ci.nodejs.org/job/node-test-commit-windows-fanned/14079/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants