Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test ppcbe for node >7 #1068

Closed
gibfahn opened this issue Jan 3, 2018 · 5 comments
Closed

Don't test ppcbe for node >7 #1068

gibfahn opened this issue Jan 3, 2018 · 5 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Jan 3, 2018

Should we stop running CI for Node > 7.x? We have this code in our release job:

if [[ $ARCH == ppc64 && ${NODE_MAJOR_VERSION} -gt 7 ]]; then
  echo "Not building $disttype on PPC Big Endian slave $NODE_NAME as not supported for v8.x and later"
  exit 0
fi
@gibfahn
Copy link
Member Author

gibfahn commented Jan 3, 2018

@mhdawson if we already discussed this somewhere else and I forgot let me know.

@mhdawson
Copy link
Member

mhdawson commented Jan 3, 2018

I've been doing it in stages without a rush.

  1. remove from main download page wait to see if we get any complaints
  2. remove generation of builds in releases, wait to see if we get any complaints..

next is remove from testing for >= 8 (not >- 7.x as you say above). I'm in no rush, but we probably have had enough time pass that stopping testing for >=8 is ok.

@gibfahn
Copy link
Member Author

gibfahn commented Jan 3, 2018

not >- 7.x as you say above

Edited.

@maclover7
Copy link
Contributor

@gibfahn @mhdawson Has node-test-commit been updated with these changes?

@mhdawson
Copy link
Member

Yes this is done closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants