Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-change: try to prune node-test-binary-windows #1493

Closed
refack opened this issue Sep 11, 2018 · 5 comments
Closed

ci-change: try to prune node-test-binary-windows #1493

refack opened this issue Sep 11, 2018 · 5 comments
Labels
ci-change PSA of configuration changes ci-public

Comments

@refack
Copy link
Contributor

refack commented Sep 11, 2018

Tracing CPU usage seems to indicate node-test-binary-windows is eating a lot of CPU, so I tried to find what could be removed, so I removed references to vs2013 (which AFAIK is relevant only for node v4). We still get VS2013 addons testing with node-gyp CI.

https://ci.nodejs.org/job/node-test-binary-windows/jobConfigHistory/showDiffFiles?timestamp1=2018-09-08_19-05-40&timestamp2=2018-09-11_16-45-26

/CC @joaocgreis

@refack refack added ci-public ci-change PSA of configuration changes labels Sep 11, 2018
@joaocgreis
Copy link
Member

Thanks for pinging about this @refack.

VS2013 should not have been removed. Testing v6 built with 2013 is still relevant. Testing addons with v6 and v8 is still very relevant, I don't think the node-gyp job provides nearly enough coverage. We want to ensure the quality of our LTS lines right?

Did you check the workspaces in master and the jenkins-workspace servers? The Windows clean job should keep the workspaces in the agents under control, but it doesn't touch the ones in the workspace servers. If we mark the workspace servers as temporarily offline one at a time and delete all the workspaces for all jobs or just the ones bigger than some size, it might help.

Another option is create several compile and test jobs, and branch according to node major version in the fanned job, but this is more complex and would have to be staged and reviewed with temporary jobs.

@refack let me know if you can revert that and if I should take a look at the workspaces.

@joaocgreis
Copy link
Member

Reverted as discussed in IRC. I'll take a look at the workspaces.

@joaocgreis
Copy link
Member

@refack can you provide details on how you found that CPU usage was because of node-test-binary-windows? I'd like to keep investigating that. Thanks!

@refack
Copy link
Contributor Author

refack commented Sep 13, 2018

@joaocgreis see #1488 (comment)
From: https://ci.nodejs.org/monitoring?part=currentRequests

@joaocgreis
Copy link
Member

For reference, the stack is visible at https://ci.nodejs.org/monitoring?part=currentRequests . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-change PSA of configuration changes ci-public
Projects
None yet
Development

No branches or pull requests

2 participants