Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release CI should attempt to build tarballs #2204

Closed
MylesBorins opened this issue Mar 4, 2020 · 3 comments
Closed

Release CI should attempt to build tarballs #2204

MylesBorins opened this issue Mar 4, 2020 · 3 comments

Comments

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 4, 2020

We now have a second release that had an issue with missing files, that resulted in broken tarballs

:(

nodejs/node#31858

We should likely have a step in the release CI that attempts to build Node.js from the tarball after it is created. Or alternatively initially create the tarball and build all of our releases from that.

Thoughts?

@mistydemeo
Copy link

Or alternatively initially create the tarball and build all of our releases from that.

Speaking as an external packager of Node (for Homebrew), I'd love to see this adopted. Aside from fixing bugs like this, it would generally increase confidence that someone else building Node from source would get an equivalent build.

@richardlau
Copy link
Member

We have a previous issue for this: #1931

Or alternatively initially create the tarball and build all of our releases from that.

👍

@MylesBorins
Copy link
Contributor Author

closing in lieu of #1931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants