Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc-only tests in CI #287

Closed
Trott opened this issue Dec 24, 2015 · 5 comments
Closed

Doc-only tests in CI #287

Trott opened this issue Dec 24, 2015 · 5 comments

Comments

@Trott
Copy link
Member

Trott commented Dec 24, 2015

Recently, a doc-only commit broke CI. Code in the doc is extracted and run during CI tests. Rod Vagg fixed the problem but it makes me wonder if it's time to revisit the "no need to run doc-only PRs through CI" practice.

@jbergstroem suggested that perhaps there could be a doc-only CI job that only runs the relevant tests that might be affected by doc-only changes. (As far as I know, that would basically just be a subset of make test-addons at the current time, but there may be other things I'm unaware of.)

Prior conversation along these lines: nodejs/node#4411 (comment)

@Trott Trott changed the title Doc-only tests Doc-only tests in CI Dec 24, 2015
@MylesBorins
Copy link
Contributor

I also think it is really worth bringing up the question if we should be running automated tests against examples in the docs.

If we broke that out into it's own testing suite we could have a CI job to run only those tests, and just tack that CI job onto the current stack.

This could end up being very useful for LTS

@jasnell
Copy link
Member

jasnell commented Dec 25, 2015

Having a docs-only CI that ran only the potentially affected tests would be ideal. Having it clearly documented that there are, in fact, tests that depend on the docs is even more ideal

@chrisdickinson
Copy link

I'd like to second what @thealphanerd suggested — instead of pulling out code examples from docs, generating tests from them, and running them, we should just turn those examples into real tests.

Doc CI is a thing that should happen separately and should probably address different concerns than "ensure the addon API works as expected."

@jbergstroem
Copy link
Member

I think we should do both. Having a doc-specific test run could focus on other areas of testing.

@orangemocha
Copy link

fwiw, node-test-commit has a pure_docs_change option under NODES_SUBSET. Right now no tests are run. It was meant as a placeholder for docs tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants