-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc-only tests in CI #287
Comments
I also think it is really worth bringing up the question if we should be running automated tests against examples in the docs. If we broke that out into it's own testing suite we could have a CI job to run This could end up being very useful for LTS |
Having a docs-only CI that ran only the potentially affected tests would be ideal. Having it clearly documented that there are, in fact, tests that depend on the docs is even more ideal |
I'd like to second what @thealphanerd suggested — instead of pulling out code examples from docs, generating tests from them, and running them, we should just turn those examples into real tests. Doc CI is a thing that should happen separately and should probably address different concerns than "ensure the addon API works as expected." |
I think we should do both. Having a doc-specific test run could focus on other areas of testing. |
fwiw, node-test-commit has a |
Recently, a doc-only commit broke CI. Code in the doc is extracted and run during CI tests. Rod Vagg fixed the problem but it makes me wonder if it's time to revisit the "no need to run doc-only PRs through CI" practice.
@jbergstroem suggested that perhaps there could be a doc-only CI job that only runs the relevant tests that might be affected by doc-only changes. (As far as I know, that would basically just be a subset of
make test-addons
at the current time, but there may be other things I'm unaware of.)Prior conversation along these lines: nodejs/node#4411 (comment)
The text was updated successfully, but these errors were encountered: