Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all init scripts has JOBS and NODE_TEST_DIR #291

Closed
jbergstroem opened this issue Dec 27, 2015 · 4 comments
Closed

Make sure all init scripts has JOBS and NODE_TEST_DIR #291

jbergstroem opened this issue Dec 27, 2015 · 4 comments

Comments

@jbergstroem
Copy link
Member

We should populate the environment variable JOBS through ansible facts. This way we can better control parallelism in both compilation and upcoming testing.

@jbergstroem jbergstroem changed the title Make sure all init scripts has JOBS Make sure all init scripts has JOBS and NODE_TEST_DIR Jan 12, 2016
@jbergstroem
Copy link
Member Author

..also, now that NODE_COMMON_PIPE is superseded by NODE_TEST_DIR, we should set these in the init scripts as well. The path should point to a temporary folder which is on the same filesystem as where nodejs is built (it for instance needs to be /home/iojs/build on arm since its mounted through nfs).

@jbergstroem
Copy link
Member Author

Question: now that these commits has been merged to 0.10 and 0.12 branches, do we want to continue supporting NODE_COMMON_PIPE moving forward in CI? Not setting it will potentially generate a fail for really old stuff; but I don't really see where or why we'd test against older branches.

@gibfahn
Copy link
Member

gibfahn commented Oct 22, 2017

Question [...] do we want to continue supporting NODE_COMMON_PIPE moving forward in CI?

No! We should definitely remove this going forward.

@Trott
Copy link
Member

Trott commented Mar 22, 2019

Closing due to long period of inactivity. Feel free to re-open if this is a thing. I'm just trying to close stuff that has been ignored for sufficiently long that it seems likely it's not something we're going to get to.

@Trott Trott closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants