Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ubuntu 14.04 ppc64le #1075

Closed
wants to merge 4 commits into from
Closed

WIP: ubuntu 14.04 ppc64le #1075

wants to merge 4 commits into from

Conversation

jBarz
Copy link
Contributor

@jBarz jBarz commented Jan 8, 2018

Enable ubuntu 14.04 ppc64le.
Have both gcc 4.8 and 4.9 on machine available

mhdawson

This comment was marked as off-topic.

@mhdawson
Copy link
Member

If you have used this to configure ubuntu1404-ppc64_le-3 I think the next step is to connect it up to the so that we can validate the machine works as a test worker.

The one thing we should probably test as part of that is the selection of the 4.9 versus 4.8 compiler. We should either have a script in the build repo for that or have that script isntalled as part of the ansible setup. It may make sense to be part of what is installed by the ansible scirpts as we'd need to update when we add support for a new compiler level which would also require ansible script updates.

@jBarz
Copy link
Contributor Author

jBarz commented Jan 19, 2018

I have run the ansible script successfuly on ubuntu1404-ppc64_le-3.
To build node using gcc-v4.8, we need to set the following. Equivalent for 4.9.

export CC=/usr/bin/gcc-4.8
export CXX=/usr/bin/g++-4.8
export LINK=/usr/bin/g++-4.8
export LDFLAGS="-Wl,-rpath,$(dirname $($CC --print-file-name libgcc_s.so))"

@mhdawson
Copy link
Member

I think next step is create test CI job as clone of existing job and do run against ubuntu1404-ppc64_le-3.

I would like to check in a script into the build repo called something like set_gcc_level that would looks at the files checked out for Node.js (likely the version info) and then sets the required exports.

The main downside is that we'd need a clone of the build repo but I don't think that would be a big deal. @nodejs/build any concerns?

@maclover7
Copy link
Contributor

Checking scripts into the build repo is fine by me. https://github.com/nodejs/build/tree/master/jenkins/scripts has some prior work, if helpful at all.

@maclover7
Copy link
Contributor

ping @jBarz

@mhdawson
Copy link
Member

mhdawson commented Feb 5, 2018

@jBarz The paths don't seem to be quite right based on the ansible setup. I had to add the path to java 8 to get the jenkins agent to start: /home/iojs/jdk8u144-b01/jre/bin/java in jenkins.conf.

jenkins.conf probably either needs to have the path updated like I did or probably better the path so that it include/home/iojs/jdk8u144-b01/jre/bins

whatever the change it will need to be specific to ppcle

@mhdawson
Copy link
Member

mhdawson commented Feb 6, 2018

Tests ran/passed for the 3 combinations.

@mhdawson
Copy link
Member

mhdawson commented Feb 6, 2018

PR for script to select compiler level: #1103 that was tested in runs above on be-3.

@jBarz
Copy link
Contributor Author

jBarz commented Feb 6, 2018

I modified the ansible script to append "/home/iojs/.profile" with
export PATH=/home/iojs/jdk8u144-b01/bin:\$PATH

Is this an acceptable solution?
We are assuming that Jenkins will only run as "iojs".

@maclover7
Copy link
Contributor

@jBarz Seems reasonable to me.

@mhdawson Can you run these scripts again on all ppc machines and confirm everything's ok? After that, please land at will.

@mhdawson
Copy link
Member

mhdawson commented Feb 8, 2018

@maclover7 can you review/approve #1103 as its related to this work.

@maclover7
Copy link
Contributor

@mhdawson Approved 1103. Once this is ready, please feel free to land in master, and then please run on all PPC machines to confirm everything's OK.

@mhdawson
Copy link
Member

mhdawson commented Feb 8, 2018

Unfortunately the change to set the path does not quite work as the script that starts the worker sets the path directly. Will discuss with @jBarz to figure out how to fix.

@jBarz jBarz force-pushed the master branch 2 times, most recently from 3570961 to e062922 Compare February 9, 2018 17:46
@mhdawson
Copy link
Member

mhdawson commented Feb 9, 2018

Looks good with latest update from @jBarz

mhdawson

This comment was marked as off-topic.

mhdawson

This comment was marked as off-topic.

mhdawson pushed a commit that referenced this pull request Feb 9, 2018
PR-URL: #1075
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

mhdawson commented Feb 9, 2018

Landed as 443f72e

@gibfahn gibfahn closed this Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants