From f18997b733f451ef3676b594e6026fca4c446c10 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 7 Sep 2023 09:24:39 -0700 Subject: [PATCH 1/3] lookup: declare bankruptcy on flaky modules Remove all modules that failed the latest 20.x release run. We need to be able to trust that a failed CITGM run is something that needs to be investigated. --- lib/lookup.json | 118 ++++-------------------------------- lib/package-manager/test.js | 2 +- test/test-lookup.js | 5 +- 3 files changed, 14 insertions(+), 111 deletions(-) diff --git a/lib/lookup.json b/lib/lookup.json index a55744bdc..e56a72036 100644 --- a/lib/lookup.json +++ b/lib/lookup.json @@ -55,10 +55,6 @@ "prefix": "v", "skip": ["win32", "aix"] }, - "bluebird": { - "prefix": "v", - "maintainers": "petkaantonov" - }, "body-parser": { "flaky": "aix", "maintainers": "dougwilson" @@ -90,7 +86,7 @@ "maintainers": "mcollina", "flaky": ["rhel"], "prefix": "v", - "skip": ["aix", "win32"] + "skip": ["aix", "darwin", "win32"] }, "coffeescript": { "maintainers": ["jashkenas", "GeoffreyBooth"], @@ -105,20 +101,11 @@ "maintainers": "ctalkington", "skip": "win32" }, - "csv-parser": { - "prefix": "v", - "flaky": "win32", - "maintainers": "mafintosh" - }, "debug": { "maintainers": ["qix", "tootallnate"], "skip": [true, "aix", "ppc", "s390", "win32"], "scripts": ["test:node", "lint"] }, - "dicer": { - "prefix": "v", - "maintainers": "mscdex" - }, "duplexer2": { "prefix": "v", "maintainers": ["shinn", "deoxxa"] @@ -127,14 +114,6 @@ "prefix": "v", "maintainers": "mafintosh" }, - "ember-cli": { - "envVar": { "YARN_IGNORE_ENGINES": "true" }, - "prefix": "v", - "flaky": ["win32", "rhel", "sles"], - "head": true, - "expectFail": "fips", - "maintainers": ["stefanpenner", "rwjblue", "Turbo87", "kellyselden"] - }, "end-of-stream": { "prefix": "v", "maintainers": "mafintosh", @@ -153,19 +132,10 @@ "expectFail": "fips", "skip": ["win32"] }, - "express": { - "flaky": "ppc", - "maintainers": "dougwilson", - "skip": "win32" - }, "express-session": { "prefix": "v", "maintainers": "dougwilson" }, - "fastify": { - "maintainers": ["mcollina", "delvedor"], - "prefix": "v" - }, "flush-write-stream": { "prefix": "v", "maintainers": "mafintosh", @@ -214,10 +184,6 @@ "maintainers": "contra", "skip": "win32" }, - "https-proxy-agent": { - "maintainers": "TooTallNate", - "scripts": ["build", "test"] - }, "iconv": { "prefix": "v", "flaky": "aix", @@ -235,6 +201,7 @@ }, "is-core-module": { "prefix": "v", + "skip": "win32", "maintainers": "ljharb", "scripts": ["tests-only"] }, @@ -277,13 +244,6 @@ "maintainers": ["ralphtheninja", "vweevers"], "skip": "win32" }, - "leveldown": { - "prefix": "v", - "useGitClone": true, - "flaky": ["ppc", "s390"], - "tags": "native", - "maintainers": ["ralphtheninja", "vweevers"] - }, "libxmljs": { "prefix": "v", "flaky": ["aix", "sles", "rhel", "darwin"], @@ -308,13 +268,10 @@ "tags": "native", "maintainers": "wadey" }, - "mime": { - "prefix": "v", - "maintainers": "broofa" - }, "minimist": { "npm": true, - "maintainers": "substack" + "skip": "win32", + "maintainers": "ljharb" }, "mkdirp": { "head": true, @@ -332,18 +289,6 @@ "maintainers": "ichernev", "skip": [true, "ppc", "s390"] }, - "multer": { - "prefix": "v", - "skip": "win32", - "maintainers": "linusu" - }, - "nan": { - "maintainers": ["nodejs/addon-api"], - "prefix": "v", - "scripts": ["rebuild-tests", "test"], - "tags": "native", - "head": true - }, "node-gyp": { "envVar": { "FAST_TEST": "true" }, "prefix": "v", @@ -358,11 +303,6 @@ "comment": "Flaky because of test timeouts", "skip": true }, - "npm": { - "maintainers": ["nodejs/npm"], - "prefix": "v", - "skip": ["aix", "s390"] - }, "path-to-regexp": { "prefix": "v", "maintainers": "blakeembrey", @@ -386,11 +326,6 @@ "comment": "Error message changes in V8 9.3", "repo": "https://github.com/pugjs/pug" }, - "pump": { - "prefix": "v", - "maintainers": "mafintosh", - "skip": "win32" - }, "pumpify": { "prefix": "v", "maintainers": "mafintosh", @@ -426,17 +361,8 @@ }, "rewire": { "prefix": "v", - "maintainers": "jhnns" - }, - "rimraf": { - "prefix": "v", - "flaky": "win32", - "maintainers": "isaacs" - }, - "router": { - "prefix": "v", - "maintainers": "dougwilson", - "skip": "win32" + "maintainers": "jhnns", + "scripts": ["test -- --timeout 30000"] }, "sax": { "skip": "win32", @@ -454,10 +380,8 @@ }, "serialport": { "prefix": "serialport@", - "flaky": ["ppc", "rhel"], "tags": "native", - "maintainers": "reconbot", - "skip": ["win32"] + "maintainers": "reconbot" }, "socket.io": { "maintainers": "rauchg", @@ -497,7 +421,9 @@ "tape": { "head": true, "prefix": "v", - "maintainers": "substack" + "skip": "win32", + "scripts": ["tests-only"], + "maintainers": "ljharb" }, "thread-sleep": { "install": ["install", "--build-from-source"], @@ -517,13 +443,6 @@ "stripAnsi": true, "maintainers": "mcollina" }, - "torrent-stream": { - "prefix": "v", - "maintainers": "mafintosh" - }, - "tough-cookie": { - "maintainers": ["awaterma", "colincasey", "ruoho", "wjharney"] - }, "uglify-js": { "prefix": "v", "flaky": ["ppc", "darwin"], @@ -531,16 +450,6 @@ "skip": ["12", true], "comment": "Tests timeout" }, - "underscore": { - "flaky": ["aix", "s390"], - "skip": "win32", - "maintainers": "jashkenas", - "ignoreGitHead": true - }, - "undici": { - "prefix": "v", - "maintainers": ["mcollina", "ronag"] - }, "uuid": { "prefix": "v", "maintainers": ["ctavan", "broofa"], @@ -568,13 +477,10 @@ "maintainers": "tootallnate", "tags": "native" }, - "winston": { - "flaky": ["win32", "ppc", "s390", "darwin"], - "maintainers": "indexzero" - }, "ws": { "expectFail": "fips", - "maintainers": ["einaros", "3rd-Eden", "lpinca"] + "maintainers": ["einaros", "3rd-Eden", "lpinca"], + "scripts": ["test -- --timeout 30000"] }, "yargs": { "comment": "Install from source is currently broken due to TS error", diff --git a/lib/package-manager/test.js b/lib/package-manager/test.js index 2e0d2054b..8d30b26a1 100644 --- a/lib/package-manager/test.js +++ b/lib/package-manager/test.js @@ -76,7 +76,7 @@ export async function test(packageManager, context) { scripts = context.module.scripts.map((script) => [ packageManagerBin, 'run', - script + ...script.split(' ') ]); } else { scripts = [[packageManagerBin, 'test']]; diff --git a/test/test-lookup.js b/test/test-lookup.js index 637d10399..4c821edb0 100644 --- a/test/test-lookup.js +++ b/test/test-lookup.js @@ -65,10 +65,7 @@ test('lookup[getLookupTable]:', (t) => { }); t.ok(table, 'table should exist'); t.ok(table.lodash, 'lodash should be in the table'); - t.ok( - table.underscore.maintainers, - 'underscore should contain a maintainers parameter' - ); + t.ok(table.weak.maintainers, 'weak should contain a maintainers parameter'); t.end(); }); From 0693e0f499b67e3db15cbe9b8d364ed9b60fcee1 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 24 Sep 2023 11:44:39 -0700 Subject: [PATCH 2/3] fixup! lookup: declare bankruptcy on flaky modules --- lib/lookup.json | 51 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/lib/lookup.json b/lib/lookup.json index e56a72036..17341ad90 100644 --- a/lib/lookup.json +++ b/lib/lookup.json @@ -101,11 +101,20 @@ "maintainers": "ctalkington", "skip": "win32" }, + "csv-parser": { + "prefix": "v", + "flaky": "win32", + "maintainers": "mafintosh" + }, "debug": { "maintainers": ["qix", "tootallnate"], "skip": [true, "aix", "ppc", "s390", "win32"], "scripts": ["test:node", "lint"] }, + "dicer": { + "prefix": "v", + "maintainers": "mscdex" + }, "duplexer2": { "prefix": "v", "maintainers": ["shinn", "deoxxa"] @@ -114,6 +123,14 @@ "prefix": "v", "maintainers": "mafintosh" }, + "ember-cli": { + "envVar": { "YARN_IGNORE_ENGINES": "true" }, + "prefix": "v", + "flaky": ["win32", "rhel", "sles"], + "head": true, + "expectFail": "fips", + "maintainers": ["stefanpenner", "rwjblue", "Turbo87", "kellyselden"] + }, "end-of-stream": { "prefix": "v", "maintainers": "mafintosh", @@ -244,6 +261,13 @@ "maintainers": ["ralphtheninja", "vweevers"], "skip": "win32" }, + "leveldown": { + "prefix": "v", + "useGitClone": true, + "flaky": ["ppc", "s390"], + "tags": "native", + "maintainers": ["ralphtheninja", "vweevers"] + }, "libxmljs": { "prefix": "v", "flaky": ["aix", "sles", "rhel", "darwin"], @@ -268,6 +292,11 @@ "tags": "native", "maintainers": "wadey" }, + "mime": { + "prefix": "v", + "maintainers": "broofa", + "skip": "win32" + }, "minimist": { "npm": true, "skip": "win32", @@ -289,6 +318,18 @@ "maintainers": "ichernev", "skip": [true, "ppc", "s390"] }, + "multer": { + "prefix": "v", + "skip": "win32", + "maintainers": "linusu" + }, + "nan": { + "maintainers": ["nodejs/addon-api"], + "prefix": "v", + "scripts": ["rebuild-tests", "test"], + "tags": "native", + "head": true + }, "node-gyp": { "envVar": { "FAST_TEST": "true" }, "prefix": "v", @@ -443,6 +484,10 @@ "stripAnsi": true, "maintainers": "mcollina" }, + "torrent-stream": { + "prefix": "v", + "maintainers": "mafintosh" + }, "uglify-js": { "prefix": "v", "flaky": ["ppc", "darwin"], @@ -455,6 +500,12 @@ "maintainers": ["ctavan", "broofa"], "skip": ["win32", "aix"] }, + "underscore": { + "flaky": ["aix", "s390"], + "skip": "win32", + "maintainers": "jashkenas", + "ignoreGitHead": true + }, "vinyl": { "prefix": "v", "maintainers": ["contra", "phated"], From ebe04c6613fae0a00b74732805a15c0078ff1560 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 24 Sep 2023 14:36:22 -0700 Subject: [PATCH 3/3] fixup! fixup! lookup: declare bankruptcy on flaky modules --- lib/lookup.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/lookup.json b/lib/lookup.json index 17341ad90..f0646e18e 100644 --- a/lib/lookup.json +++ b/lib/lookup.json @@ -495,17 +495,17 @@ "skip": ["12", true], "comment": "Tests timeout" }, - "uuid": { - "prefix": "v", - "maintainers": ["ctavan", "broofa"], - "skip": ["win32", "aix"] - }, "underscore": { "flaky": ["aix", "s390"], "skip": "win32", "maintainers": "jashkenas", "ignoreGitHead": true }, + "uuid": { + "prefix": "v", + "maintainers": ["ctavan", "broofa"], + "skip": ["win32", "aix"] + }, "vinyl": { "prefix": "v", "maintainers": ["contra", "phated"],