Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub webhook not restarting the server? #279

Closed
mmarchini opened this issue Aug 10, 2020 · 2 comments
Closed

GitHub webhook not restarting the server? #279

mmarchini opened this issue Aug 10, 2020 · 2 comments

Comments

@mmarchini
Copy link
Contributor

So I merged #275 today, but the bot was still behaving like before the PR. I just logged into the bot instance and noticed the bot server was running since Aug 9 0:06 UTC, the PR was merged at Aug 9 21:07 UTC. The repository folder was correctly updated, but the server didn't restart to apply the changes. Is the server supposed to restart when a new commit is merged, or does it restart once a day (or only manually)?

@phillipj
Copy link
Member

Hmz, strange. It is supposed to restart as soon as commits lands to master, here is the relevant github-webhook configuration in the build repo:

I've noticed blipps of it not working from time to time, both for the github-bot and in nodejs.org which has a very similar github-webhook setup.

Looking at the webhook events log under this repo' Settings-page doesn't give any valuable hints either. The two most recent push events sent to the github-bot server succeeded:

Screenshot 2020-08-10 at 10 40 04

Bottom line; I don't know why it didn't restart. Let's keep an eye on it going forward and dig deeper if the issue persists?

@Trott
Copy link
Member

Trott commented Sep 19, 2024

I don't think we're seeing this problem anymore, so I'm going to close this. Pinging @richardlau in case he knows differently and wants to re-open.

@Trott Trott closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants