Experimental node_api_nogc_env is not stripped

[legendecas]

Ref:

node-api-headers/include/js_native_api_types.h

Lines 46 to 53 in 1294543

	#if !defined(NAPI_EXPERIMENTAL) || \
	(defined(NAPI_EXPERIMENTAL) && \
	(defined(NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT) || \
	defined(NODE_API_EXPERIMENTAL_BASIC_ENV_OPT_OUT)))
	typedef struct napi_env__* node_api_nogc_env;
	#else
	typedef const struct napi_env__* node_api_nogc_env;
	#endif

All other NAPI_EXPERIMENTAL apis were stripped, but node_api_nogc_env and node_api_nogc_finalize were not.

If NAPI_EXPERIMENTAL is defined, node_api_post_finalizer is missing for node_api_nogc_finalize callbacks.

[KevinEady]

Root problem: the current experimental stripping can only support #if(n)def NAPI_EXPERIMENTAL, and so the conditional here is a bit too complex:

node-api-headers/scripts/update-headers.js

Line 49 in 1294543

if (matches = line.match(/^\s*#if(n)?def\s+([A-Za-z_][A-Za-z0-9_]*)/)) {

[KevinEady]

We discussed in the 11 Oct Node-API meeting a possible solution of modifying the Node.js header files such that it would be easier for the tool to correctly remove experimental features.

Thinking about it some more, I am not a big fan of this approach. I don't think we should "dumb down" the header files just because the tool isn't smart enough.

I am looking into making the tool more robust and handling #if as well.

[legendecas]

Just a idea: do we really need to strip experimental APIs?

If the experimental APIs were not stripped, it could be tested in nodejs/node-addon-api#1585 as well.

[NickNaso]

What I remember about the decision to strip experimental APIs is that we would like to avoid developers use APIs that could be removed and then breaks their build.