-
Notifications
You must be signed in to change notification settings - Fork 96
[Converge] lib: fix stdio/ipc sync i/o regression #34
Comments
Hah, that actually landed in joyent/node? Like I said in the other issue, I think it's better to embrace the asynchronous nature of process.send(). Now at least its behavior is consistent on Windows and UNIX. |
Ok, so what do we want to do with this one then? It looks to me like landing this in node was likely premature given the additional discussion on the io.js side. This would mean a change of behavior from v0.12 to the first converged release so we'll need to document it. |
I suggest we use the major for this as a breaking change and document it. |
@Fishrock123 ... Ok, then I think this is added to the list of breaking changes from v0.12 to the converged release. /cc @misterdjules I'm not sure if I quite understand the change enough myself to document it, however. |
Moving discussion back to nodejs/node#760 tbh I don't really know where this stands, if we make it officially async do we have to change the non-windows implementations? we'd need to change the docs too I suppose. It would be great to get rid of the Known Issues item for this. |
This became async in nodejs/node@56d9584, closing. |
See nodejs/node-v0.x-archive@2411bea
/cc: @bnoordhuis @trevnorris
Original commit message:
The text was updated successfully, but these errors were encountered: