Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong state after fixing git am conflict #277

Closed
targos opened this issue Sep 4, 2018 · 4 comments
Closed

Wrong state after fixing git am conflict #277

targos opened this issue Sep 4, 2018 · 4 comments

Comments

@targos
Copy link
Member

targos commented Sep 4, 2018

I was trying to land nodejs/node#21992 which had a small conflict to fix.

So I ran:

git node land 21992
# stopped at `git am`. fix conflict
git add .
git am --continue
git node land --continue

At this point, it tries to re-download and apply the patch.

@joyeecheung
Copy link
Member

Are you using master or the npm release? It may be fixed by 34664c0

@targos
Copy link
Member Author

targos commented Sep 7, 2018

The npm release. I didn't realize it was so for behind, sorry.

@joyeecheung
Copy link
Member

No worries, I'll publish a new release

@targos
Copy link
Member Author

targos commented Sep 7, 2018

Thank you! Since it's not common to land PRs which still have conflicts, I'll close this as likely fixed.

@targos targos closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants