Skip to content

Commit

Permalink
Drop dependency on minimatch.
Browse files Browse the repository at this point in the history
PR-URL: #1158
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
  • Loading branch information
doowb authored and bnoordhuis committed Jun 8, 2018
1 parent 1e203c5 commit 88fc6fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
5 changes: 2 additions & 3 deletions lib/install.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ var fs = require('graceful-fs')
, semver = require('semver')
, fstream = require('fstream')
, request = require('request')
, minimatch = require('minimatch')
, mkdir = require('mkdirp')
, processRelease = require('./process-release')
, win = process.platform == 'win32'
Expand Down Expand Up @@ -401,8 +400,8 @@ function install (fs, gyp, argv, callback) {

function valid (file) {
// header files
return minimatch(file, '*.h', { matchBase: true }) ||
minimatch(file, '*.gypi', { matchBase: true })
var extname = path.extname(file);
return extname === '.h' || extname === '.gypi';
}

/**
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"fstream": "^1.0.0",
"glob": "^7.0.3",
"graceful-fs": "^4.1.2",
"minimatch": "^3.0.2",
"mkdirp": "^0.5.0",
"nopt": "2 || 3",
"npmlog": "0 || 1 || 2 || 3 || 4",
Expand Down

0 comments on commit 88fc6fa

Please sign in to comment.