-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
claims that PR is not accepted yet #8
Comments
I see a proper result there:
Google Chrome 59.0.3048.0 Canary |
Are you using the latest version? That pr did not work for either until I pulled the latest from master and then reloading the extension. |
That was the issue, out of date, thanks. I forgot that this hadn't been installed normally, and the extension doesn't auto-update. Its working after update. |
Glad you got it working. I really need to get it published to the chrome app store, just haven't had a chance to. I'll try to do that sometime this week or next... |
Oh, no! I don't think I can live without node-review anymore, and its not working for me with nodejs/node#5923
It claims
Yes, that is the empty list, because all reviewers have accepted the changes. Just me, or is it a problem for other people? I haven't landed any changes for almost 2 weeks (vacation, travel), so I don't know if this is new or not.
I wonder if its coincidental that I recently reported a bug to github where some reviewers listed in the conversation review summary at the bottom of the thread were not listed in the review area at the top-right of the page, a problem they fixed a week or so ago.
The text was updated successfully, but these errors were encountered: