crypto: use EVP_PKEY_X448 in GetEphemeralKeyInfo

PR-URL: #26988 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
nodejs · Apr 1, 2019 · 05bd607 · 05bd607
1 parent 6ac692a
commit 05bd607
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -2452,8 +2452,8 @@ void SSLWrap<Base>::GetEphemeralKeyInfo(
             .FromJust();
         break;
       case EVP_PKEY_EC:
-      // TODO(shigeki) Add EVP_PKEY_X448.
       case EVP_PKEY_X25519:
+      case EVP_PKEY_X448:
         {
           const char* curve_name;
           if (kid == EVP_PKEY_EC) {

diff --git a/test/parallel/test-tls-client-getephemeralkeyinfo.js b/test/parallel/test-tls-client-getephemeralkeyinfo.js
@@ -60,3 +60,4 @@ test(2048, 'DH', undefined, 'DHE-RSA-AES128-GCM-SHA256');
 test(256, 'ECDH', 'prime256v1', 'ECDHE-RSA-AES128-GCM-SHA256');
 test(521, 'ECDH', 'secp521r1', 'ECDHE-RSA-AES128-GCM-SHA256');
 test(253, 'ECDH', 'X25519', 'ECDHE-RSA-AES128-GCM-SHA256');
+test(448, 'ECDH', 'X448', 'ECDHE-RSA-AES128-GCM-SHA256');