util: fix indentationLvl when exceeding max call stack size

The inspection indentation level was not always reset to it's former value in case the maximum call stack size was exceeded. Backport-PR-URL: #23039 PR-URL: #22787 Reviewed-By: James M Snell <[email protected]>
nodejs · Sep 24, 2018 · 077e7e0 · 077e7e0
1 parent 5a13e66
commit 077e7e0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -832,6 +832,7 @@ function formatRaw(ctx, value, recurseTimes) {
 
   ctx.seen.push(value);
   let output;
+  const indentationLvl = ctx.indentationLvl;
   try {
     output = formatter(ctx, value, recurseTimes, keys);
     if (skip === false) {
@@ -841,16 +842,17 @@ function formatRaw(ctx, value, recurseTimes) {
       }
     }
   } catch (err) {
-    return handleMaxCallStackSize(ctx, err, constructor, tag);
+    return handleMaxCallStackSize(ctx, err, constructor, tag, indentationLvl);
   }
   ctx.seen.pop();
 
   return reduceToSingleString(ctx, output, base, braces);
 }
 
-function handleMaxCallStackSize(ctx, err, constructor, tag) {
+function handleMaxCallStackSize(ctx, err, constructor, tag, indentationLvl) {
   if (errors.isStackOverflowError(err)) {
     ctx.seen.pop();
+    ctx.indentationLvl = indentationLvl;
     return ctx.stylize(
       `[${constructor || tag || 'Object'}: Inspection interrupted ` +
         'prematurely. Maximum call stack size exceeded.]',