lib: optimize copyError with ObjectAssign in primordials

optimized the copyError function by using ObjectAssign from primordials. this change replaces the for-loop with ObjectAssign, which improves memory usage and performance. this change updates the copyError function in internal/assert.js to use ObjectAssign for copying properties. PR-URL: #53999 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
nodejs · Aug 19, 2024 · 0d70c79 · 0d70c79
1 parent bfabfb4
commit 0d70c79
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/internal/assert/assertion_error.js b/lib/internal/assert/assertion_error.js
@@ -6,9 +6,9 @@ const {
   Error,
   ErrorCaptureStackTrace,
   MathMax,
+  ObjectAssign,
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
-  ObjectKeys,
   String,
   StringPrototypeEndsWith,
   StringPrototypeRepeat,
@@ -46,11 +46,7 @@ const kReadableOperator = {
 const kMaxShortLength = 12;
 
 function copyError(source) {
-  const keys = ObjectKeys(source);
-  const target = { __proto__: ObjectGetPrototypeOf(source) };
-  for (const key of keys) {
-    target[key] = source[key];
-  }
+  const target = ObjectAssign({ __proto__: ObjectGetPrototypeOf(source) }, source);
   ObjectDefineProperty(target, 'message', { __proto__: null, value: source.message });
   return target;
 }