From 18c9913ce18135953ef1ac02ded8604de9f42e2c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 11 Apr 2021 07:34:20 -0700 Subject: [PATCH] test: add tests for missing https agent options Add test that minVersion and maxVersion options are accepted. This should complete coverage for lib/https.js. Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js PR-URL: https://github.com/nodejs/node/pull/38202 Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- test/parallel/test-https-agent-additional-options.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/parallel/test-https-agent-additional-options.js b/test/parallel/test-https-agent-additional-options.js index b596fdcc169d55..543ee176fb6af3 100644 --- a/test/parallel/test-https-agent-additional-options.js +++ b/test/parallel/test-https-agent-additional-options.js @@ -36,6 +36,8 @@ const updatedValues = new Map([ ['dhparam', fixtures.readKey('dh2048.pem')], ['ecdhCurve', 'secp384r1'], ['honorCipherOrder', true], + ['minVersion', 'TLSv1.1'], + ['maxVersion', 'TLSv1.3'], ['secureOptions', crypto.constants.SSL_OP_CIPHER_SERVER_PREFERENCE], ['secureProtocol', 'TLSv1_1_method'], ['sessionIdContext', 'sessionIdContext'],