Skip to content

Commit

Permalink
deps: workaround debug link error on Windows
Browse files Browse the repository at this point in the history
PR-URL: #38807
Refs: #38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
  • Loading branch information
richardlau authored and nodejs-github-bot committed Oct 13, 2021
1 parent 9f0bc60 commit 228e703
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.10',
'v8_embedder_string': '-node.11',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/src/objects/fixed-array.h
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ class FixedArray
inline void set(int index, Smi value);
#else
inline void set(int index, Smi value) {
#if !defined(_WIN32)
DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map());
#endif
DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length()));
DCHECK(Object(value).IsSmi());
int offset = OffsetOfElementAt(index);
Expand Down

0 comments on commit 228e703

Please sign in to comment.