From 228e703dedf0102a6af627a13926f85b693adab1 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 30 Sep 2021 11:45:53 -0400 Subject: [PATCH] deps: workaround debug link error on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/38807 Refs: https://github.com/nodejs/node/pull/38788 Reviewed-By: Antoine du Hamel Reviewed-By: Jiawen Geng Reviewed-By: James M Snell Reviewed-By: Juan José Arboleda Reviewed-By: Michaël Zasso Reviewed-By: Ash Cripps --- common.gypi | 2 +- deps/v8/src/objects/fixed-array.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 3ad21b22551206..c0427c25a02be6 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/objects/fixed-array.h b/deps/v8/src/objects/fixed-array.h index 6b0ac5d9acaca1..8488371744fa16 100644 --- a/deps/v8/src/objects/fixed-array.h +++ b/deps/v8/src/objects/fixed-array.h @@ -138,7 +138,9 @@ class FixedArray inline void set(int index, Smi value); #else inline void set(int index, Smi value) { +#if !defined(_WIN32) DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map()); +#endif DCHECK_LT(static_cast(index), static_cast(length())); DCHECK(Object(value).IsSmi()); int offset = OffsetOfElementAt(index);