From 2ce236e1739277788af6a353d0a4c845d45515ea Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 15 Jun 2017 13:53:42 -0700 Subject: [PATCH] build: check for linter in bin rather than lib Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. PR-URL: https://github.com/nodejs/node/pull/13645 Reviewed-By: Teddy Katz Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann Reviewed-By: Sam Roberts Reviewed-By: Alexey Orlenko Reviewed-By: James M Snell --- Makefile | 2 +- vcbuild.bat | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1aa317c88f01f0..ae4925af0c91bd 100644 --- a/Makefile +++ b/Makefile @@ -903,7 +903,7 @@ cpplint: @$(PYTHON) tools/cpplint.py $(CPPLINT_FILES) @$(PYTHON) tools/check-imports.py -ifneq ("","$(wildcard tools/eslint/lib/eslint.js)") +ifneq ("","$(wildcard tools/eslint/bin/eslint.js)") lint: @EXIT_STATUS=0 ; \ $(MAKE) jslint || EXIT_STATUS=$$? ; \ diff --git a/vcbuild.bat b/vcbuild.bat index 41a82e1551af87..6a77d9ae85abb3 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -472,7 +472,7 @@ goto exit :jslint if defined jslint_ci goto jslint-ci if not defined jslint goto exit -if not exist tools\eslint\lib\eslint.js goto no-lint +if not exist tools\eslint\bin\eslint.js goto no-lint echo running jslint %config%\node tools\eslint\bin\eslint.js --cache --rule "linebreak-style: 0" --rulesdir=tools\eslint-rules --ext=.js,.md benchmark doc lib test tools goto exit