From 33e3eb44f75c3d6e60a016b9ec72233bfa3e2460 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 6 Oct 2018 15:36:08 -0700 Subject: [PATCH] doc: update onboarding task Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: https://github.com/nodejs/node/pull/23300 Reviewed-By: Vse Mozhet Byt Reviewed-By: Refael Ackermann Reviewed-By: Colin Ihrig --- doc/onboarding.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index ef7f328a311697..0c46318a7857bb 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -210,11 +210,12 @@ needs to be pointed out separately during the onboarding. -1` * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. -* Label your pull request with the `doc` and `notable-change` labels. +* Label your pull request with the `doc`, `notable-change`, and `fast-track` + labels. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite-pipeline` CI task. -* After one or two approvals, land the PR (PRs of this type do not need to wait - for 48 hours to land). +* After two Collaborator approvals for the change and two Collaborator approvals + for fast-tracking, land the PR. * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing