Skip to content

Commit

Permalink
src: remove unused fields msg_ and env_
Browse files Browse the repository at this point in the history
Currently the following compiler warnings are generated:

../src/node_messaging.cc:74:16:
warning: private field 'env_' is not used [-Wunused-private-field]
  Environment* env_;
               ^
../src/node_messaging.cc:75:12:
warning: private field 'msg_' is not used [-Wunused-private-field]
  Message* msg_;
           ^
2 warnings generated.

This commit removes these unused private members.

PR-URL: #20876
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
  • Loading branch information
danbev authored and targos committed Jun 13, 2018
1 parent d1f372f commit 5209ff9
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions src/node_messaging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
const std::vector<MessagePort*>& message_ports,
const std::vector<Local<SharedArrayBuffer>>&
shared_array_buffers)
: env_(env),
msg_(m),
message_ports_(message_ports),
: message_ports_(message_ports),
shared_array_buffers_(shared_array_buffers) {}

MaybeLocal<Object> ReadHostObject(Isolate* isolate) override {
Expand All @@ -71,8 +69,6 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
ValueDeserializer* deserializer = nullptr;

private:
Environment* env_;
Message* msg_;
const std::vector<MessagePort*>& message_ports_;
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers_;
};
Expand Down

0 comments on commit 5209ff9

Please sign in to comment.