test: fix domain with abort-on-uncaught on PPC

Add SIGTRAP and the corresponding exit code to the list of signals/exit codes that are expected when running tests that throw an uncaught error and have --abort-on-uncaught-exception enabled. Also refactor a bit related comments so that they better reflect what's actually happening. Fixes #3239. PR: #3354 PR-URL: #3354 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
nodejs · Oct 28, 2015 · 5222fcc · 5222fcc
1 parent fb3b848
commit 5222fcc
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/test/parallel/test-domain-with-abort-on-uncaught-exception.js b/test/parallel/test-domain-with-abort-on-uncaught-exception.js
@@ -135,20 +135,16 @@ if (process.argv[2] === 'child') {
             // --abort_on_uncaught_exception is passed on the command line,
             // the process must abort.
             //
-            // We use an array of values since the actual exit code can differ
-            // across compilers.
             // Depending on the compiler used, node will exit with either
-            // exit code 132 (SIGILL) or 134 (SIGABRT).
-            expectedExitCodes = [132, 134];
-
-            // On platforms using a non-GNU compiler, base::OS::Abort raises
-            // an illegal instruction signal.
-            // On platforms using a GNU compiler but with KSH being the
-            // default shell (like SmartOS), when a process aborts, KSH exits
-            // with an exit code that is greater than 256, and thus the exit
-            // code emitted with the 'exit' event is null and the signal is
-            // set to either SIGABRT or SIGILL.
-            expectedSignals = ['SIGABRT', 'SIGILL'];
+            // exit code 132 (SIGILL), 133 (SIGTRAP) or 134 (SIGABRT).
+            expectedExitCodes = [132, 133, 134];
+
+            // On platforms using KSH as the default shell (like SmartOS),
+            // when a process aborts, KSH exits with an exit code that is
+            // greater than 256, and thus the exit code emitted with the 'exit'
+            // event is null and the signal is set to either SIGILL, SIGTRAP,
+            // or SIGABRT (depending on the compiler).
+            expectedSignals = ['SIGILL', 'SIGTRAP', 'SIGABRT'];
 
             // On Windows, v8's base::OS::Abort triggers an access violation,
             // which corresponds to exit code 3221225477 (0xC0000005)