async_hooks: avoid GC tracking of AsyncResource in ALS

Manually destroy the AsyncResource created by AsyncLocalStore.run() to avoid unneeded GC tracking in case a destroy hooks is present. PR-URL: #34653 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Aug 8, 2020 · 6502489 · 6502489
1 parent e89ec46
commit 6502489
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/async_hooks.js b/lib/async_hooks.js
@@ -253,6 +253,7 @@ const storageHook = createHook({
   }
 });
 
+const defaultAlsResourceOpts = { requireManualDestroy: true };
 class AsyncLocalStorage {
   constructor() {
     this.kResourceStore = Symbol('kResourceStore');
@@ -293,8 +294,11 @@ class AsyncLocalStorage {
     if (ObjectIs(store, this.getStore())) {
       return callback(...args);
     }
-    const resource = new AsyncResource('AsyncLocalStorage');
-    return resource.runInAsyncScope(() => {
+    const resource = new AsyncResource('AsyncLocalStorage',
+                                       defaultAlsResourceOpts);
+    // Calling emitDestroy before runInAsyncScope avoids a try/finally
+    // It is ok because emitDestroy only schedules calling the hook
+    return resource.emitDestroy().runInAsyncScope(() => {
       this.enterWith(store);
       return callback(...args);
     });