From 67205391b398351f0e7bd69e2b812ae94f67004a Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Sat, 23 Sep 2017 13:09:07 +0100 Subject: [PATCH] src: move node_trace_writer/buffer.h to agent.cc The headers node_trace_writer.h and node_trace_buffer.h are not used in agent.h but are more of an implementation detail of agent.cc. This commit suggests moving the inclusion of these headers to agent.cc. PR-URL: https://github.com/nodejs/node/pull/15598 Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig --- src/tracing/agent.cc | 2 ++ src/tracing/agent.h | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/tracing/agent.cc b/src/tracing/agent.cc index 1ac99bbb34bbbf..bc04b0b5e60d17 100644 --- a/src/tracing/agent.cc +++ b/src/tracing/agent.cc @@ -2,6 +2,8 @@ #include #include +#include "tracing/node_trace_buffer.h" +#include "tracing/node_trace_writer.h" #include "env-inl.h" diff --git a/src/tracing/agent.h b/src/tracing/agent.h index e781281712bbf6..59a7912631d75a 100644 --- a/src/tracing/agent.h +++ b/src/tracing/agent.h @@ -1,15 +1,16 @@ #ifndef SRC_TRACING_AGENT_H_ #define SRC_TRACING_AGENT_H_ +#include "libplatform/v8-tracing.h" #include "node_platform.h" -#include "tracing/node_trace_buffer.h" -#include "tracing/node_trace_writer.h" #include "uv.h" #include "v8.h" namespace node { namespace tracing { +using v8::platform::tracing::TracingController; + class Agent { public: Agent();