From 6838ad5f8e46bd3a62f6c3bf9b50cc5a4312a2ee Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Wed, 13 Jul 2016 16:16:52 +0200
Subject: [PATCH] src: fix handle leak in UDPWrap::Instantiate()

Create a handle scope before performing a check that creates a handle,
otherwise the handle is leaked into the handle scope of the caller.

PR-URL: https://github.com/nodejs/node/pull/7711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
---
 src/udp_wrap.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc
index e395ee85e0852e..e0f51cbf589699 100644
--- a/src/udp_wrap.cc
+++ b/src/udp_wrap.cc
@@ -394,9 +394,9 @@ void UDPWrap::OnRecv(uv_udp_t* handle,
 
 
 Local<Object> UDPWrap::Instantiate(Environment* env, AsyncWrap* parent) {
+  EscapableHandleScope scope(env->isolate());
   // If this assert fires then Initialize hasn't been called yet.
   CHECK_EQ(env->udp_constructor_function().IsEmpty(), false);
-  EscapableHandleScope scope(env->isolate());
   Local<Value> ptr = External::New(env->isolate(), parent);
   return scope.Escape(env->udp_constructor_function()->NewInstance(1, &ptr));
 }