From 77dee25efd2fb114a56e83a165a97fef22c68316 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 4 Apr 2019 10:49:29 -0700 Subject: [PATCH] benchmark: remove deprecated argument The benchmarks for dns.lookup() include calling it with an empty hostname which results in a deprecation warning. This benchmark seems to be subject to some odd side effects (see Ref below) and we probably generally don't want to benchmark deprecated things by default anyway. Remove the deprecated value from the default list. Bonus is that this will speed up the benchmark. Refs: https://github.com/nodejs/node/pull/27081#issuecomment-479981874 PR-URL: https://github.com/nodejs/node/pull/27091 Reviewed-By: Ruben Bridgewater Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca --- benchmark/dns/lookup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark/dns/lookup.js b/benchmark/dns/lookup.js index 3cc228c5669265..164e490bd3bc24 100644 --- a/benchmark/dns/lookup.js +++ b/benchmark/dns/lookup.js @@ -4,7 +4,7 @@ const common = require('../common.js'); const lookup = require('dns').lookup; const bench = common.createBenchmark(main, { - name: ['', '127.0.0.1', '::1'], + name: ['127.0.0.1', '::1'], all: ['true', 'false'], n: [5e6] });