test: use assert() in N-API async test

The `Execute()` callback is not allowed to call into JS, so we should use `assert()` instead of potentially throwing JS errors. PR-URL: #28423 Fixes: nodejs/help#1998 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · Jul 2, 2019 · 79b1bf5 · 79b1bf5
1 parent 14f6cee
commit 79b1bf5
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/test/node-api/test_async/test_async.cc b/test/node-api/test_async/test_async.cc
@@ -1,3 +1,4 @@
+#include <assert.h>
 #include <stdio.h>
 #include <node_api.h>
 #include "../../js-native-api/common.h"
@@ -29,10 +30,7 @@ void Execute(napi_env env, void* data) {
 #endif
   carrier* c = static_cast<carrier*>(data);
 
-  if (c != &the_carrier) {
-    napi_throw_type_error(env, nullptr, "Wrong data parameter to Execute.");
-    return;
-  }
+  assert(c == &the_carrier);
 
   c->_output = c->_input * 2;
 }