process: support symbol events

Event emitters support symbols as event names. The process object assumes that the event name is a string, and examines the first three characters to check for signals. This causes an exception if the event name is a symbol. This commit ensures that the event name is a string before trying to slice() it. PR-URL: #4798 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Wyatt Preul <[email protected]>
nodejs · Feb 18, 2016 · 7a2e8f4 · 7a2e8f4
1 parent 0887208
commit 7a2e8f4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/node.js b/src/node.js
@@ -782,7 +782,8 @@
     var signalWraps = {};
 
     function isSignal(event) {
-      return event.slice(0, 3) === 'SIG' &&
+      return typeof event === 'string' &&
+             event.slice(0, 3) === 'SIG' &&
              startup.lazyConstants().hasOwnProperty(event);
     }
 

diff --git a/test/parallel/test-process-emit.js b/test/parallel/test-process-emit.js
@@ -0,0 +1,20 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const sym = Symbol();
+
+process.on('normal', common.mustCall(data => {
+  assert.strictEqual(data, 'normalData');
+}));
+
+process.on(sym, common.mustCall(data => {
+  assert.strictEqual(data, 'symbolData');
+}));
+
+process.on('SIGPIPE', common.mustCall(data => {
+  assert.strictEqual(data, 'signalData');
+}));
+
+process.emit('normal', 'normalData');
+process.emit(sym, 'symbolData');
+process.emit('SIGPIPE', 'signalData');