From 7a2e8f435637be1053e80198345d06ddd75cc303 Mon Sep 17 00:00:00 2001
From: cjihrig <cjihrig@gmail.com>
Date: Thu, 21 Jan 2016 13:07:25 -0500
Subject: [PATCH] process: support symbol events
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Event emitters support symbols as event names. The process object
assumes that the event name is a string, and examines the first
three characters to check for signals. This causes an exception
if the event name is a symbol. This commit ensures that the
event name is a string before trying to slice() it.

PR-URL: https://github.com/nodejs/node/pull/4798
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
---
 src/node.js                        |  3 ++-
 test/parallel/test-process-emit.js | 20 ++++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 test/parallel/test-process-emit.js

diff --git a/src/node.js b/src/node.js
index c194c239ca5866..41e8fb1957d788 100644
--- a/src/node.js
+++ b/src/node.js
@@ -782,7 +782,8 @@
     var signalWraps = {};
 
     function isSignal(event) {
-      return event.slice(0, 3) === 'SIG' &&
+      return typeof event === 'string' &&
+             event.slice(0, 3) === 'SIG' &&
              startup.lazyConstants().hasOwnProperty(event);
     }
 
diff --git a/test/parallel/test-process-emit.js b/test/parallel/test-process-emit.js
new file mode 100644
index 00000000000000..0e6d28b22a66e4
--- /dev/null
+++ b/test/parallel/test-process-emit.js
@@ -0,0 +1,20 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const sym = Symbol();
+
+process.on('normal', common.mustCall(data => {
+  assert.strictEqual(data, 'normalData');
+}));
+
+process.on(sym, common.mustCall(data => {
+  assert.strictEqual(data, 'symbolData');
+}));
+
+process.on('SIGPIPE', common.mustCall(data => {
+  assert.strictEqual(data, 'signalData');
+}));
+
+process.emit('normal', 'normalData');
+process.emit(sym, 'symbolData');
+process.emit('SIGPIPE', 'signalData');