util: runtime deprecate util.isError

PR-URL: #50488 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Nov 27, 2023 · 7c69c33 · 7c69c33
1 parent a0c5b87
commit 7c69c33
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -1058,6 +1058,9 @@ The [`util.isDate()`][] API is deprecated.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/50488
+    description: Runtime deprecation.
   - version:
     - v6.12.0
     - v4.8.6
@@ -1070,9 +1073,11 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime
 
-The [`util.isError()`][] API is deprecated.
+The [`util.isError()`][] API is deprecated. Please use
+`Object.prototype.toString(arg) === '[object Error]' || arg instanceof Error`
+instead.
 
 ### DEP0049: `util.isFunction()`
 

diff --git a/lib/util.js b/lib/util.js
@@ -430,9 +430,13 @@ module.exports = {
                       'The `util.isObject` API is deprecated. Please use `typeof arg === "object"` instead.',
                       'DEP0053'),
   isDate: deprecate(types.isDate,
-                    'The `util.isDate` API is deprecated.  Please use `arg instanceof Error` instead.',
+                    'The `util.isDate API is deprecated.  Please use `arg instanceof Error` instead.',
                     'DEP0047'),
-  isError: deprecate(isError, 'The `util.isError API is deprecated.', 'DEP0048'),
+  isError: deprecate(isError,
+                     'The `util.isError` API is deprecated. ' +
+                     'Please use `ObjectPrototypeToString(e) === "[object Error]" ' +
+                     '|| e instanceof Error` instead.',
+                     'DEP0048'),
   isFunction: deprecate(isFunction, 'The `util.isFunction API is deprecated.', 'DEP0049'),
   isPrimitive: deprecate(isPrimitive, 'The `util.isPrimitive API is deprecated.', 'DEP0054'),
   log: deprecate(log, 'The `util.log API is deprecated.', 'DEP0059'),