From 82cf0f2f3c9e4c6f9c28cd130e91287d93200373 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 25 Jul 2024 10:33:38 -0700 Subject: [PATCH] test: add comments and rename test for timer robustness The name of the test did not make it clear what it was about. (It also used "timer" in the name instead of "timers" like all the other tests.) I also added a comment to be extra clear about the test purpose and a link to the issue that was originally filed about it. PR-URL: https://github.com/nodejs/node/pull/54008 Reviewed-By: Luigi Pinca Reviewed-By: Chengzhong Wu Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell Reviewed-By: Jake Yuesong Li --- ...est-timer-immediate.js => test-timers-process-tampering.js} | 3 +++ 1 file changed, 3 insertions(+) rename test/parallel/{test-timer-immediate.js => test-timers-process-tampering.js} (51%) diff --git a/test/parallel/test-timer-immediate.js b/test/parallel/test-timers-process-tampering.js similarity index 51% rename from test/parallel/test-timer-immediate.js rename to test/parallel/test-timers-process-tampering.js index b0f52db1b713d3..766cc9f3560c82 100644 --- a/test/parallel/test-timer-immediate.js +++ b/test/parallel/test-timers-process-tampering.js @@ -1,3 +1,6 @@ +// Check that setImmediate works even if process is tampered with. +// This is a regression test for https://github.com/nodejs/node/issues/17681. + 'use strict'; const common = require('../common'); global.process = {}; // Boom!