doc,lib,test: rename node-report to report

This commit completes the renaming of node-report to report in order to better differentiate core's reporting from the node-report npm module. PR-URL: #26371 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 4, 2019 · 8814d03 · 8814d03
1 parent 11bd5e0
commit 8814d03
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/doc/api/report.md b/doc/api/report.md
@@ -32,7 +32,7 @@ is provided below for reference.
       "/home/nodeuser/project/node/out/Release/node",
       "--experimental-report",
       "--diagnostic-report-uncaught-exception",
-      "/home/nodeuser/project/node/test/node-report/test-exception.js",
+      "/home/nodeuser/project/node/test/report/test-exception.js",
       "child"
     ],
     "nodejsVersion": "v12.0.0-pre",
@@ -66,8 +66,8 @@ is provided below for reference.
   "javascriptStack": {
     "message": "Error: *** test-exception.js: throwing uncaught Error",
     "stack": [
-      "at myException (/home/nodeuser/project/node/test/node-report/test-exception.js:9:11)",
-      "at Object.<anonymous> (/home/nodeuser/project/node/test/node-report/test-exception.js:12:3)",
+      "at myException (/home/nodeuser/project/node/test/report/test-exception.js:9:11)",
+      "at Object.<anonymous> (/home/nodeuser/project/node/test/report/test-exception.js:12:3)",
       "at Module._compile (internal/modules/cjs/loader.js:718:30)",
       "at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)",
       "at Module.load (internal/modules/cjs/loader.js:617:32)",

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
@@ -11,7 +11,7 @@ function prepareMainThreadExecution() {
   // Only main thread receives signals.
   setupSignalHandlers();
 
-  // Process initial configurations of node-report, if any.
+  // Process initial diagnostic reporting configuration, if present.
   initializeReport();
   initializeReportSignalHandlers();  // Main-thread-only.
 

diff --git a/lib/internal/process/execution.js b/lib/internal/process/execution.js
@@ -102,7 +102,7 @@ function createFatalException() {
     // call that threw and was never cleared. So clear it now.
     clearDefaultTriggerAsyncId();
 
-    // If node-report is enabled, call into its handler to see
+    // If diagnostic reporting is enabled, call into its handler to see
     // whether it is interested in handling the situation.
     // Ignore if the error is scoped inside a domain.
     // use == in the checks as we want to allow for null and undefined
@@ -119,7 +119,7 @@ function createFatalException() {
             report.onUnCaughtException(er ? er.stack : undefined);
           }
         }
-      } catch {}  // NOOP, node_report unavailable.
+      } catch {}  // Ignore the exception. Diagnostic reporting is unavailable.
     }
 
     if (exceptionHandlerState.captureFn !== null) {

diff --git a/test/common/index.js b/test/common/index.js
@@ -635,7 +635,7 @@ function skipIfInspectorDisabled() {
 
 function skipIfReportDisabled() {
   if (!process.config.variables.node_report) {
-    skip('Node Report is disabled');
+    skip('Diagnostic reporting is disabled');
   }
 }