test: runner should return 0 on flaky tests

Make the test runner return a 0 exit code when only flaky tests fail and --flaky-tests=dontcare is specified. Ported from nodejs/node-v0.x-archive@a9b642c PR-URL: #2424 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
nodejs · Aug 28, 2015 · 8f8ab6f · 8f8ab6f
1 parent 0cfd3be
commit 8f8ab6f
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/tools/test.py b/tools/test.py
@@ -75,7 +75,9 @@ def __init__(self, cases, flaky_tests_mode):
     self.remaining = len(cases)
     self.total = len(cases)
     self.failed = [ ]
+    self.flaky_failed = [ ]
     self.crashed = 0
+    self.flaky_crashed = 0
     self.lock = threading.Lock()
     self.shutdown_event = threading.Event()
 
@@ -143,9 +145,14 @@ def RunSingle(self, parallel, thread_id):
         return
       self.lock.acquire()
       if output.UnexpectedOutput():
-        self.failed.append(output)
-        if output.HasCrashed():
-          self.crashed += 1
+        if FLAKY in output.test.outcomes and self.flaky_tests_mode == DONTCARE:
+          self.flaky_failed.append(output)
+          if output.HasCrashed():
+            self.flaky_crashed += 1
+        else:
+          self.failed.append(output)
+          if output.HasCrashed():
+            self.crashed += 1
       else:
         self.succeeded += 1
       self.remaining -= 1