bindings: close after reading module struct

Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: #2792 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]>
nodejs · Sep 11, 2015 · 9683e5d · 9683e5d
1 parent 82ba183
commit 9683e5d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/node.cc b/src/node.cc
@@ -2087,12 +2087,15 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
     return;
   }
   if (mp->nm_version != NODE_MODULE_VERSION) {
-    uv_dlclose(&lib);
     char errmsg[1024];
     snprintf(errmsg,
              sizeof(errmsg),
              "Module version mismatch. Expected %d, got %d.",
              NODE_MODULE_VERSION, mp->nm_version);
+
+    // NOTE: `mp` is allocated inside of the shared library's memory, calling
+    // `uv_dlclose` will deallocate it
+    uv_dlclose(&lib);
     env->ThrowError(errmsg);
     return;
   }