Skip to content

Commit

Permalink
doc: onboarding process extras
Browse files Browse the repository at this point in the history
Callout some practices explicitly, so that
the process is followed in a similar manner

PR-URL: #34455
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
  • Loading branch information
gireeshpunathil authored and MylesBorins committed Jul 27, 2020
1 parent bbc7eea commit 99a6487
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,9 @@ needs to be pointed out separately during the onboarding.
* Run CI on the PR. Use the `node-test-pull-request` CI task.
* After two Collaborator approvals for the change and two Collaborator approvals
for fast-tracking, land the PR.
* Leave a comment in the PR: `Please 👍 this comment to approve fast-tracking`.
* If there are not enough approvals within a reasonable time, consider the
single approval of the onboarding TSC member sufficient, and land the PR.
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
metadata.
* [`node-core-utils`][] automates the generation of metadata and the landing
Expand Down

0 comments on commit 99a6487

Please sign in to comment.