tools: forbid template literals in assert.throws

Extend the assert-throws-arguments custom ESLint rule to also check for the use of template literals as a second argument to assert.throws. PR-URL: #10301 Ref: #10282 (comment) Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
nodejs · Feb 1, 2017 · 9f13b5f · 9f13b5f
1 parent c801de9
commit 9f13b5f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/tools/eslint-rules/assert-throws-arguments.js b/tools/eslint-rules/assert-throws-arguments.js
@@ -21,7 +21,8 @@ function checkThrowsArguments(context, node) {
       });
     } else if (args.length > 1) {
       const error = args[1];
-      if (error.type === 'Literal' && typeof error.value === 'string') {
+      if (error.type === 'Literal' && typeof error.value === 'string' ||
+          error.type === 'TemplateLiteral') {
         context.report({
           message: 'Unexpected string as second argument',
           node: error