From a24264eb18962a1fdbc5a4d10fd7bcf65a401a54 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Sat, 28 Jan 2017 21:18:55 -0800
Subject: [PATCH] src: fix v8 local handling in node_url.cc

Calling `.As<Object>()` on a non-object aborts in debug mode,
but `node_url.cc` relied on it. Address that by using `Local<Value>`
until it has been confirmed that the handle actually is an object.

PR-URL: https://github.com/nodejs/node/pull/11064
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 src/node_url.cc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/node_url.cc b/src/node_url.cc
index 92cb8efbb84389..7f21051c54e5ac 100644
--- a/src/node_url.cc
+++ b/src/node_url.cc
@@ -636,8 +636,8 @@ namespace url {
                     const char* input,
                     const size_t len,
                     enum url_parse_state override,
-                    Local<Object> base_obj,
-                    Local<Object> context_obj,
+                    Local<Value> base_obj,
+                    Local<Value> context_obj,
                     Local<Function> cb) {
     Isolate* isolate = env->isolate();
     Local<Context> context = env->context();
@@ -654,9 +654,9 @@ namespace url {
     struct url_data base;
     struct url_data url;
     if (context_obj->IsObject())
-      HarvestContext(env, &url, context_obj);
+      HarvestContext(env, &url, context_obj.As<Object>());
     if (has_base)
-      HarvestBase(env, &base, base_obj);
+      HarvestBase(env, &base, base_obj.As<Object>());
 
     std::string buffer;
     url.scheme.reserve(len);
@@ -1321,8 +1321,8 @@ namespace url {
     Parse(env, args.This(),
           *input, input.length(),
           override,
-          args[2].As<Object>(),
-          args[3].As<Object>(),
+          args[2],
+          args[3],
           args[4].As<Function>());
   }