src: remove node_options-inl.h from header files

Fix unnecessary inclusion of node_options-inl.h into env.h via inspector_agent.h, causing almost all of src/ to recompile on any change to the options parser. Its intended that *-inl.h header files are only included into the src files that call the inline methods. PR-URL: #27538 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · May 5, 2019 · a758f9b · a758f9b
1 parent d648ecc
commit a758f9b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -9,6 +9,7 @@
 #include "node/inspector/protocol/Protocol.h"
 #include "node_errors.h"
 #include "node_internals.h"
+#include "node_options-inl.h"
 #include "node_process.h"
 #include "node_url.h"
 #include "v8-inspector.h"

diff --git a/src/inspector_agent.h b/src/inspector_agent.h
@@ -6,7 +6,7 @@
 #error("This header can only be used when inspector is enabled")
 #endif
 
-#include "node_options-inl.h"
+#include "node_options.h"
 #include "v8.h"
 
 #include <cstddef>

diff --git a/src/node_worker.cc b/src/node_worker.cc
@@ -2,6 +2,7 @@
 #include "debug_utils.h"
 #include "node_errors.h"
 #include "node_buffer.h"
+#include "node_options-inl.h"
 #include "node_perf.h"
 #include "util.h"
 #include "async_wrap-inl.h"