Revert "console: use consolePropAttributes for k-bind properties in c…

…onstructor" This reverts commit ed5e69d. PR-URL: #26943 Refs: #26850 (comment) Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
nodejs · Mar 27, 2019 · a8eac78 · a8eac78
1 parent ed5e69d
commit a8eac78
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -181,13 +181,15 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) {
       ...consolePropAttributes,
       value: Boolean(ignoreErrors)
     },
-    '_times': { ...consolePropAttributes, value: new Map() },
-    // Corresponds to https://console.spec.whatwg.org/#count-map
-    [kCounts]: { ...consolePropAttributes, value: new Map() },
-    [kColorMode]: { ...consolePropAttributes, value: colorMode },
-    [kIsConsole]: { ...consolePropAttributes, value: true },
-    [kGroupIndent]: { ...consolePropAttributes, value: '' }
+    '_times': { ...consolePropAttributes, value: new Map() }
   });
+
+  // TODO(joyeecheung): use consolePropAttributes for these
+  // Corresponds to https://console.spec.whatwg.org/#count-map
+  this[kCounts] = new Map();
+  this[kColorMode] = colorMode;
+  this[kIsConsole] = true;
+  this[kGroupIndent] = '';
 };
 
 // Make a function that can serve as the callback passed to `stream.write()`.