From b5e3fca04cda736d4a3edcdd4f61d7686291821b Mon Sep 17 00:00:00 2001 From: Mary Marchini Date: Sun, 9 Aug 2020 22:53:22 -0700 Subject: [PATCH] build: set --v8-enable-object-print by default The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: https://github.com/nodejs/node/pull/32834 PR-URL: https://github.com/nodejs/node/pull/34705 Reviewed-By: Jiawen Geng Reviewed-By: David Carlier --- common.gypi | 3 +++ configure.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 3e654273bfc853..f5d6dc077a67af 100644 --- a/common.gypi +++ b/common.gypi @@ -54,6 +54,9 @@ # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, + # Sets -dOBJECT_PRINT. + 'v8_enable_object_print%': 1, + # https://github.com/nodejs/node/pull/22920/files#r222779926 'v8_enable_handle_zapping': 0, diff --git a/configure.py b/configure.py index 2327089e1237ee..fc702ce06fbbaf 100755 --- a/configure.py +++ b/configure.py @@ -709,7 +709,7 @@ parser.add_option('--v8-enable-object-print', action='store_true', dest='v8_enable_object_print', - default=False, + default=True, help='compile V8 with auxiliar functions for native debuggers') parser.add_option('--node-builtin-modules-path',